http://www.ssbits.com/home/ http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_413 Thanks for this! Led me the way to the light! By the way: the link to the SilverStripe pagination tutorial/recipe in the article is broken, it currently resides here: http://doc.silverstripe.org/old/private:recipes:pagination RSSName http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_413 http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_226 Thanks Marcus! That's very helpful. Nice tutorial writing too - it will be great if you get the go-ahead to revise it. RSSName http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_226 http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_225 Yes pretty much. You have to use Manuels code in every getter where you want to paginate a DataObjectSet that needs to be filtered after the db query. You could also write a helper function with the stuff that Manuel suggests and use that every time you need to do this. I'd do a method called paginate() that accepts the relevant DOSet and returns the paginated version. That method would keep track of the GET variables etc so you wouldn't have to clutter the getter with that stuff. I'll ask Aram if it's ok and if it is, I'll change this tutorial to how I'd actually do it today. RSSName http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_225 http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_224 Sorry - just to clarify I'm doing things right: - Manuel's code makes all your code obsolete - you place it in a PageController (or equivalent) - you can access different pages through the url with ?start= (is there a cleaner ss way of doing this?) Am I right? Cheers & thanks RSSName http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_224 http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_153 @Manuel Man I'd actually missed the getRange() method! I could have sworn I searched for an equivalent to array_slice() but couldn't find it but it's right there. Manuels way of doing it actually makes more sense, it becomes easier in the template since you'll always be using the same object for all of it and you skip the __call() so it should be faster as well. RSSName http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_153 http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_152 Hi, my solution for pagination of custom DataObjectSets looks like this: public function getChildPages() { $kids = DataObject::get('ViewableObjectsHolder', "ParentID = '{$this->ID}'", 'Sort'); foreach ($kids as $kid) { $kid->controller = ModelAsController::controller_for($kid); } return $kids; } public function getChildObjects($items_per_page = 10) { $objects = new DataObjectSet(); $kids = $this->getChildPages(); foreach ($kids as $kid) { $objects->merge($kid->controller->getObjects('', false)); } if (empty($items_per_page) || $items_per_page < 1) $items_per_page = 10; if(!isset($_GET['start']) || !is_numeric($_GET['start']) || (int)$_GET['start'] < 1) $_GET['start'] = 0; $o = $objects->getRange((int)$_GET['start'], (int)$items_per_page); $o->setPageLimits((int)$_GET['start'], (int)$items_per_page, $objects->Count()); return $o; } The important lines are the last ones of the 'getChildObjects' method. Hope it helps... RSSName http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_152 http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_139 @Daniel That sounds pretty awesome. Would you just cache the results from the query and filtering and live with the cost of slicing a really big array or would you try to find a way to cache each page separately? Also how big would you let the result set get before you'd seriously start considering going the cache route? Just caching the results after the filtering seems to be pretty trivial with cacheToFile() if I'm reading the code correctly. Thank you for the awesome tip, I will be trying it out soon. RSSName http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_139 http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_138 @Marcus Yes, there is a very simple way to cache an output of a function. I use two methods, one is this in the init() of a controller: $this->FuncName = $this->cacheToFile('FuncName',$lifetime,$ID,(array)$arguments); The other is this: function() FuncName() { if (!isset($this->FuncName) { $this->FuncName = some complicated fetching etc; } return $this->FuncName; I might write a lil tut on caching in the contoller RSSName http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_138 http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_137 You can take a look at Aram's custom search mod hidden in the forums. http://www.silverstripe.org/all-other-modules/show/6641?start=24#post290089 Specially the part from r303 at $records = DB::query($fullQuery); After the query the result will be pushed in a DO set as well, but its much smaller, since its not getting the full DataObjects. That still does not prevent you checking canView on each DO though... RSSName http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_137 http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_136 Hi Dan, Unfortunately no, I don't think there is an easy way around this unless you cache the initial query and filtering in some way. The big issue is that you're filtering after the results have been fetched, presumably because you can't filter the result directly in the database query. If you can filter in the database query that's of course alot better but there needs to be some kind of solution for when you can't too. Is there a simple way to cache a DataObjectSet in SilverStripe? If there is then let me know and we can add that to the tutorial. It would be really nice to cache the filtered result after the first query and then just use that on subsequent calls. Has anyone tried caching DataObjectSets and knows how to go about this? RSSName http://www.ssbits.com/tutorials/2010/paginating-a-filtered-dataobjectset/#PageComment_136